Skip to content

Improve ORM definitions #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Improve ORM definitions #1270

merged 1 commit into from
Apr 14, 2025

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Apr 12, 2025

Just a sync of the ORM definitions I have on my fork and the main LORIS-MRI repo after #1257. This PR includes a few stylistic changes (whitespaces), a few renamings (0-to-n relations being put in plural form), a relationship fix (due to a bad review of mine 😬), a new model and a few new queries (unused in LORIS-MRI main for now).

@maximemulder maximemulder added Area: ORM PR or issue related to the SQLAlchemy integration Difficulty: Simple PR or issue that should be easy to implement, review, or test labels Apr 12, 2025
@maximemulder maximemulder requested a review from cmadjar April 12, 2025 08:53
@maximemulder maximemulder force-pushed the improve_orm branch 3 times, most recently from 869e181 to 9c54782 Compare April 12, 2025 09:03
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmadjar cmadjar merged commit 04a12ba into aces:main Apr 14, 2025
9 checks passed
@cmadjar cmadjar added this to the 27.0 milestone Apr 17, 2025
@maximemulder maximemulder deleted the improve_orm branch April 18, 2025 08:52
@cmadjar cmadjar added this to the 27.0 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ORM PR or issue related to the SQLAlchemy integration Difficulty: Simple PR or issue that should be easy to implement, review, or test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants